hw/xen: Avoid use of uninitialized bufioreq_evtchn
authorEdgar E. Iglesias <edgar.iglesias@amd.com>
Mon, 7 Oct 2024 16:53:13 +0000 (18:53 +0200)
committerEdgar E. Iglesias <edgar.iglesias@amd.com>
Mon, 21 Oct 2024 05:53:21 +0000 (07:53 +0200)
Avoid use of uninitialized bufioreq_evtchn. It should only
be used if buffered IOREQs are enabled.

Resolves: Coverity CID 1563383
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
hw/xen/xen-hvm-common.c

index 7d2b72853b3293a88152cae5b2b3a5bfb534af54..7ffbbfea23b33b8f1d85f4569b7c8fcc01e88a96 100644 (file)
@@ -752,9 +752,10 @@ static int xen_map_ioreq_server(XenIOState *state)
         return -1;
     }
 
-    trace_xen_map_ioreq_server_buffered_io_evtchn(bufioreq_evtchn);
-
-    state->bufioreq_remote_port = bufioreq_evtchn;
+    if (state->has_bufioreq) {
+        trace_xen_map_ioreq_server_buffered_io_evtchn(bufioreq_evtchn);
+        state->bufioreq_remote_port = bufioreq_evtchn;
+    }
 
     return 0;
 }