leds: cr0014114: Annotate struct cr0014114 with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 15 Sep 2023 20:09:48 +0000 (13:09 -0700)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 11:28:26 +0000 (11:28 +0000)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct cr0014114.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230915200948.never.728-kees@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-cr0014114.c

index b33bca397ea60df451f31cd3dcafa40f0ac7475e..c9914fc51f202331e673d2fda97c243ee7467e5a 100644 (file)
@@ -56,7 +56,7 @@ struct cr0014114 {
        struct spi_device       *spi;
        u8                      *buf;
        unsigned long           delay;
-       struct cr0014114_led    leds[];
+       struct cr0014114_led    leds[] __counted_by(count);
 };
 
 static void cr0014114_calc_crc(u8 *buf, const size_t len)