usb: dwc3: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions
authorAnand Moon <linux.amoon@gmail.com>
Fri, 12 Apr 2024 14:22:54 +0000 (19:52 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Apr 2024 14:48:23 +0000 (16:48 +0200)
This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to
care about when the functions are actually used.

Also make use of pm_sleep_ptr() to discard all PM_SLEEP related
stuff if CONFIG_PM_SLEEP isn't enabled.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20240412142317.5191-6-linux.amoon@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-exynos.c

index 5d365ca51771dead5045d32ae9351cc2253a8a3a..3427522a7c6abec3aa20c84e52fdb2dddb7930c7 100644 (file)
@@ -187,7 +187,6 @@ static const struct of_device_id exynos_dwc3_match[] = {
 };
 MODULE_DEVICE_TABLE(of, exynos_dwc3_match);
 
-#ifdef CONFIG_PM_SLEEP
 static int dwc3_exynos_suspend(struct device *dev)
 {
        struct dwc3_exynos *exynos = dev_get_drvdata(dev);
@@ -230,14 +229,8 @@ static int dwc3_exynos_resume(struct device *dev)
        return 0;
 }
 
-static const struct dev_pm_ops dwc3_exynos_dev_pm_ops = {
-       SET_SYSTEM_SLEEP_PM_OPS(dwc3_exynos_suspend, dwc3_exynos_resume)
-};
-
-#define DEV_PM_OPS     (&dwc3_exynos_dev_pm_ops)
-#else
-#define DEV_PM_OPS     NULL
-#endif /* CONFIG_PM_SLEEP */
+static DEFINE_SIMPLE_DEV_PM_OPS(dwc3_exynos_dev_pm_ops,
+                               dwc3_exynos_suspend, dwc3_exynos_resume);
 
 static struct platform_driver dwc3_exynos_driver = {
        .probe          = dwc3_exynos_probe,
@@ -245,7 +238,7 @@ static struct platform_driver dwc3_exynos_driver = {
        .driver         = {
                .name   = "exynos-dwc3",
                .of_match_table = exynos_dwc3_match,
-               .pm     = DEV_PM_OPS,
+               .pm     = pm_sleep_ptr(&dwc3_exynos_dev_pm_ops),
        },
 };