qca: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Michael Heimpold <michael.heimpold@i2se.com>
Cc: Yangtao Li <tiny.windzz@gmail.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c
index bcb890b18a944d1ab7d47834993c7475943edf33..702aa217a27ad4c8021665f18c37b9db8e17e25a 100644 (file)
--- a/drivers/net/ethernet/qualcomm/qca_debug.c
+++ b/drivers/net/ethernet/qualcomm/qca_debug.c
@@ -131,17 +131,10 @@ DEFINE_SHOW_ATTRIBUTE(qcaspi_info);
 void
 qcaspi_init_device_debugfs(struct qcaspi *qca)
 {
-       struct dentry *device_root;
+       qca->device_root = debugfs_create_dir(dev_name(&qca->net_dev->dev),
+                                             NULL);
 
-       device_root = debugfs_create_dir(dev_name(&qca->net_dev->dev), NULL);
-       qca->device_root = device_root;
-
-       if (IS_ERR(device_root) || !device_root) {
-               pr_warn("failed to create debugfs directory for %s\n",
-                       dev_name(&qca->net_dev->dev));
-               return;
-       }
-       debugfs_create_file("info", S_IFREG | 0444, device_root, qca,
+       debugfs_create_file("info", S_IFREG | 0444, qca->device_root, qca,
                            &qcaspi_info_fops);
 }