mt76: mt7921: fix retrying release semaphore without end
authorSean Wang <sean.wang@mediatek.com>
Tue, 14 Sep 2021 15:50:22 +0000 (23:50 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:16:37 +0000 (19:16 +0100)
[ Upstream commit 02d1c7d494d8052288bc175e4ff54b56d08a3c5f ]

We should pass the error code to the caller immediately
to avoid the possible infinite retry to release the semaphore.

Fixes: 1c099ab44727 ("mt76: mt7921: add MCU support")
Co-developed-by: YN Chen <YN.Chen@mediatek.com>
Signed-off-by: YN Chen <YN.Chen@mediatek.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/mediatek/mt76/mt7921/mcu.c

index 3cb53c642d24253b77b75a198c38e2cce6207f0c..506a1909ce6d53e377d3c9970d40b80ec76d9bec 100644 (file)
@@ -827,7 +827,7 @@ out:
        default:
                ret = -EAGAIN;
                dev_err(dev->mt76.dev, "Failed to release patch semaphore\n");
-               goto out;
+               break;
        }
        release_firmware(fw);