wifi: mac80211: drop spurious WARN_ON() in ieee80211_ibss_csa_beacon()
authorDmitry Antipov <dmantipov@yandex.ru>
Fri, 8 Dec 2023 15:31:25 +0000 (18:31 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 12 Dec 2023 09:37:01 +0000 (10:37 +0100)
The WARN_ON() in subject was actually seen only once, with 5.10.200
under syzkaller. It looks like a weird artifact of (ab?)using the
syzkaller itself [1], and hopefully may be safely removed.

[1] https://lore.kernel.org/linux-wireless/1bd8f266-dee0-4d4e-9b50-e22546b55763@yandex.ru/T/#u

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Link: https://msgid.link/20231208153130.107409-1-dmantipov@yandex.ru
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/ibss.c

index 8b1e02f2f9ae1cc73e3eb2d58e2ead71ad5fd061..8f2b445a5ec3be939854b3fce0c9d151656939e2 100644 (file)
@@ -485,7 +485,7 @@ int ieee80211_ibss_csa_beacon(struct ieee80211_sub_if_data *sdata,
                                ifibss->ssid_len, IEEE80211_BSS_TYPE_IBSS,
                                IEEE80211_PRIVACY(ifibss->privacy));
 
-       if (WARN_ON(!cbss))
+       if (unlikely(!cbss))
                return -EINVAL;
 
        rcu_read_lock();