i2c: core: Use generic_handle_irq_safe() in i2c_handle_smbus_host_notify().
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Fri, 11 Feb 2022 18:14:55 +0000 (19:14 +0100)
committerWolfram Sang <wsa@kernel.org>
Tue, 1 Mar 2022 14:58:41 +0000 (15:58 +0100)
The i2c-i801 driver invokes i2c_handle_smbus_host_notify() from his
interrupt service routine. On PREEMPT_RT i2c-i801's handler is forced
threaded with enabled interrupts which leads to a warning by
handle_irq_event_percpu() assuming that irq_default_primary_handler()
enabled interrupts.

i2c-i801's interrupt handler can't be made non-threaded because the
interrupt line is shared with other devices.

Use generic_handle_irq_safe() which can invoked with disabled and enabled
interrupts.

Reported-by: Michael Below <below@judiz.de>
Link: https://bugs.debian.org/1002537
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/i2c-core-base.c

index 32a45260c1f3c54bec15a2c2e6bb6140baf1f2b4..d43db2c3876e7966487ceddd235d5531e0f964ff 100644 (file)
@@ -1424,7 +1424,7 @@ int i2c_handle_smbus_host_notify(struct i2c_adapter *adap, unsigned short addr)
        if (irq <= 0)
                return -ENXIO;
 
-       generic_handle_irq(irq);
+       generic_handle_irq_safe(irq);
 
        return 0;
 }