iio: adc: ti-adc108s102: Fix alignment for DMA safety
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 8 May 2022 17:56:10 +0000 (18:56 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 14 Jun 2022 10:53:14 +0000 (11:53 +0100)
____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1.  Switch to the updated
IIO_DMA_MINALIGN definition.

Dual fixes tags as two cases that were introduced in different patches.
One of those patches is a fix however and likely to have been backported
to stable kernels.

Note the second alignment marking is likely to be unnecessary, but is
left for now to keep this fix simple.

Fixes: 3691e5a69449 ("iio: adc: add driver for the ti-adc084s021 chip")
Fixes: cbe5c6977604 ("iio: adc: ti-adc108s102: Fix alignment of buffer pushed to iio buffers.")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220508175712.647246-31-jic23@kernel.org
drivers/iio/adc/ti-adc108s102.c

index c8e48881c37f93bc293edc8b21feeecd66eec1ff..c82a161630e1d97d5e9073e811d437215c325a43 100644 (file)
@@ -77,8 +77,8 @@ struct adc108s102_state {
         *  tx_buf: 8 channel read commands, plus 1 dummy command
         *  rx_buf: 1 dummy response, 8 channel responses
         */
-       __be16                          rx_buf[9] ____cacheline_aligned;
-       __be16                          tx_buf[9] ____cacheline_aligned;
+       __be16                          rx_buf[9] __aligned(IIO_DMA_MINALIGN);
+       __be16                          tx_buf[9] __aligned(IIO_DMA_MINALIGN);
 };
 
 #define ADC108S102_V_CHAN(index)                                       \