bcachefs: Fix allocator shutdown error message
authorKent Overstreet <kent.overstreet@gmail.com>
Fri, 1 Oct 2021 14:08:13 +0000 (10:08 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:09:13 +0000 (17:09 -0400)
We return 1 to indicate kthread_should_stop() returned true - we
shouldn't be printing an error.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
fs/bcachefs/alloc_background.c

index 54fbfb22d671b9cb42e9588433665fc0448a6e54..fc1b4b354b050ffa1f1fb958d104aa969e659c25 100644 (file)
@@ -857,10 +857,10 @@ static int bch2_invalidate_buckets(struct bch_fs *c, struct bch_dev *ca)
        /* If we used NOWAIT, don't return the error: */
        if (!fifo_empty(&ca->free_inc))
                ret = 0;
-       if (ret) {
+       if (ret < 0)
                bch_err(ca, "error invalidating buckets: %i", ret);
+       if (ret)
                return ret;
-       }
 
        if (journal_seq)
                ret = bch2_journal_flush_seq(&c->journal, journal_seq);