wifi: rtw88: add missing destroy_workqueue() on error path in rtw_core_init()

[ Upstream commit b0ea758b30bbdf7c4323c78b7c50c05d2e1224d5 ]

Add the missing destroy_workqueue() before return from rtw_core_init()
in error path.

Fixes: fe101716c7c9 ("rtw88: replace tx tasklet with work queue")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220826023817.3908255-1-yangyingliang@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
index 5786995d90d4d4546ed8b6b1f5c4dbbc16f06346..d7b7b2cce974609157740672fb2c0d616b58f057 100644 (file)
--- a/drivers/net/wireless/realtek/rtw88/main.c
+++ b/drivers/net/wireless/realtek/rtw88/main.c
@@ -1869,7 +1869,7 @@ int rtw_core_init(struct rtw_dev *rtwdev)
        ret = rtw_load_firmware(rtwdev, RTW_NORMAL_FW);
        if (ret) {
                rtw_warn(rtwdev, "no firmware loaded\n");
-               return ret;
+               goto out;
        }
 
        if (chip->wow_fw_name) {
@@ -1879,11 +1879,15 @@ int rtw_core_init(struct rtw_dev *rtwdev)
                        wait_for_completion(&rtwdev->fw.completion);
                        if (rtwdev->fw.firmware)
                                release_firmware(rtwdev->fw.firmware);
-                       return ret;
+                       goto out;
                }
        }
 
        return 0;
+
+out:
+       destroy_workqueue(rtwdev->tx_wq);
+       return ret;
 }
 EXPORT_SYMBOL(rtw_core_init);