tests: iter: fix potential segfault
authorBartosz Golaszewski <bartekgola@gmail.com>
Tue, 13 Jun 2017 20:04:13 +0000 (22:04 +0200)
committerBartosz Golaszewski <bartekgola@gmail.com>
Tue, 13 Jun 2017 20:04:13 +0000 (22:04 +0200)
All automatically cleaned up variables must be initialized. Otherwise
we risk calling free() on an uninitialized pointer if an assertion
fails before we assign it a value.

Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
tests/tests-iter.c

index b4f49ba4a1b843f4ef81c42fbaf0ee1bc3713d82..daee7719e674d36adcf09db83551c0b479baa7d4 100644 (file)
@@ -44,9 +44,9 @@ static void chip_iter_noclose(void)
 {
        TEST_CLEANUP(test_free_chip_iter_noclose)
                        struct gpiod_chip_iter *iter = NULL;
-       TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipA;
-       TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipB;
-       TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipC;
+       TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipA = NULL;
+       TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipB = NULL;
+       TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipC = NULL;
        struct gpiod_chip *chip;
        bool A, B, C;