wifi: iwlwifi: mvm: make a few warnings only trigger once

We're hitting these while starting to enable MLO in the
driver, but getting them each and every time isn't very
useful one way or the other. Make these warnings trigger
only once.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230329100039.f333741d3dcf.If063d4cfe8a583f0f980a1b0ae4e63e17ba4ddc9@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 294e1c1de6b6b834f2b17cda4098a1e2f3f56859..2b2221d7582b4c36f9a13125fd5e97a44c32bdde 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -5591,7 +5591,7 @@ void iwl_mvm_mac_flush(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
                        continue;
 
                /* make sure only TDLS peers or the AP are flushed */
-               WARN_ON(i != mvmvif->deflink.ap_sta_id && !sta->tdls);
+               WARN_ON_ONCE(i != mvmvif->deflink.ap_sta_id && !sta->tdls);
 
                if (drop) {
                        if (iwl_mvm_flush_sta(mvm, mvmsta, false))

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-key.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-key.c
index 154f145396ce78daa6fe484ca86bd5fe4edbf5a1..aa8b4fb9c20172d56dd1c432997aee34bea9d102 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-key.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-key.c
@@ -213,8 +213,8 @@ void iwl_mvm_sec_key_remove_ap(struct iwl_mvm *mvm,
        u32 sec_key_id = WIDE_ID(DATA_PATH_GROUP, SEC_KEY_CMD);
        u8 sec_key_ver = iwl_fw_lookup_cmd_ver(mvm->fw, sec_key_id, 0);
 
-       if (WARN_ON(vif->type != NL80211_IFTYPE_STATION ||
-                   mvmvif->deflink.ap_sta_id == IWL_MVM_INVALID_STA))
+       if (WARN_ON_ONCE(vif->type != NL80211_IFTYPE_STATION ||
+                        mvmvif->deflink.ap_sta_id == IWL_MVM_INVALID_STA))
                return;
 
        if (!sec_key_ver)