qemu: per-arch cpu_has_work (Marcelo Tosatti)

Blue Swirl: fix Sparc32 breakage

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@7238 c046a42c-6fe2-441c-8c8c-71466251a162

diff --git a/cpu-all.h b/cpu-all.h
index 1d691ddc130418bb2a178e3a36fd2a7844ade669..e8cccc646071c3cf51e6cedb76f767af910e71ec 100644 (file)
--- a/cpu-all.h
+++ b/cpu-all.h
@@ -775,6 +775,8 @@ void cpu_reset_interrupt(CPUState *env, int mask);
 
 void cpu_exit(CPUState *s);
 
+int qemu_cpu_has_work(CPUState *env);
+
 /* Breakpoint/watchpoint flags */
 #define BP_MEM_READ           0x01
 #define BP_MEM_WRITE          0x02

diff --git a/cpu-exec.c b/cpu-exec.c
index 122bdd10b8fc83fd210084d79de8793a7672b559..90f879bbf8d99be69f005176edec9609286d02e7 100644 (file)
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -50,6 +50,11 @@ int tb_invalidated_flag;
 //#define DEBUG_EXEC
 //#define DEBUG_SIGNAL
 
+int qemu_cpu_has_work(CPUState *env)
+{
+    return cpu_has_work(env);
+}
+
 void cpu_loop_exit(void)
 {
     /* NOTE: the register at this point must be saved by hand because

diff --git a/target-alpha/exec.h b/target-alpha/exec.h
index 9ea70305eff39e05c0b70a7a7604d2dfaf6fa302..77eaf53c10a1b68b968320ece5d8f07d0a2ce712 100644 (file)
--- a/target-alpha/exec.h
+++ b/target-alpha/exec.h
@@ -48,10 +48,15 @@ static always_inline void regs_to_env(void)
 {
 }
 
+static always_inline int cpu_has_work(CPUState *env)
+{
+    return (env->interrupt_request & CPU_INTERRUPT_HARD);
+}
+
 static always_inline int cpu_halted(CPUState *env) {
     if (!env->halted)
         return 0;
-    if (env->interrupt_request & CPU_INTERRUPT_HARD) {
+    if (cpu_has_work(env)) {
         env->halted = 0;
         return 0;
     }

diff --git a/target-arm/exec.h b/target-arm/exec.h
index 3e4083a61b58968f928900a65b0dd78e584b6081..710a2f98829c71e09a4ac45d9e133b7ba7439873 100644 (file)
--- a/target-arm/exec.h
+++ b/target-arm/exec.h
@@ -37,14 +37,19 @@ static inline void regs_to_env(void)
 {
 }
 
+static inline int cpu_has_work(CPUState *env)
+{
+    return (env->interrupt_request &
+            (CPU_INTERRUPT_FIQ | CPU_INTERRUPT_HARD | CPU_INTERRUPT_EXITTB));
+}
+
 static inline int cpu_halted(CPUState *env) {
     if (!env->halted)
         return 0;
     /* An interrupt wakes the CPU even if the I and F CPSR bits are
        set.  We use EXITTB to silently wake CPU without causing an
        actual interrupt.  */
-    if (env->interrupt_request &
-        (CPU_INTERRUPT_FIQ | CPU_INTERRUPT_HARD | CPU_INTERRUPT_EXITTB)) {
+    if (cpu_has_work(env)) {
         env->halted = 0;
         return 0;
     }

diff --git a/target-cris/exec.h b/target-cris/exec.h
index 77e4240e89e60033cc84784a67a845b26e1f71a5..5f3cc0017844dad75d45a359a45c950265c8d3a2 100644 (file)
--- a/target-cris/exec.h
+++ b/target-cris/exec.h
@@ -40,6 +40,11 @@ static inline void regs_to_env(void)
 void cpu_cris_flush_flags(CPUCRISState *env, int cc_op);
 void helper_movec(CPUCRISState *env, int reg, uint32_t val);
 
+static inline int cpu_has_work(CPUState *env)
+{
+    return (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI));
+}
+
 static inline int cpu_halted(CPUState *env) {
        if (!env->halted)
                return 0;

diff --git a/target-i386/exec.h b/target-i386/exec.h
index b51667a1f616d542078c34657c76bd28facecb4c..fbaf5bc9845e1dea4c852e9fa96250e786f4746b 100644 (file)
--- a/target-i386/exec.h
+++ b/target-i386/exec.h
@@ -338,14 +338,23 @@ static inline void regs_to_env(void)
 #endif
 }
 
+static inline int cpu_has_work(CPUState *env)
+{
+    int work;
+
+    work = (env->interrupt_request & CPU_INTERRUPT_HARD) &&
+           (env->eflags & IF_MASK);
+    work |= env->interrupt_request & CPU_INTERRUPT_NMI;
+
+    return work;
+}
+
 static inline int cpu_halted(CPUState *env) {
     /* handle exit of HALTED state */
     if (!env->halted)
         return 0;
     /* disable halt condition */
-    if (((env->interrupt_request & CPU_INTERRUPT_HARD) &&
-         (env->eflags & IF_MASK)) ||
-        (env->interrupt_request & CPU_INTERRUPT_NMI)) {
+    if (cpu_has_work(env)) {
         env->halted = 0;
         return 0;
     }

diff --git a/target-m68k/exec.h b/target-m68k/exec.h
index fba371cf409805b6eecd5a18c0edf970ff81aa4f..3a86b1f891752c3c0b22d2bf1587429106d0be56 100644 (file)
--- a/target-m68k/exec.h
+++ b/target-m68k/exec.h
@@ -41,10 +41,15 @@ static inline void regs_to_env(void)
 #include "softmmu_exec.h"
 #endif
 
+static inline int cpu_has_work(CPUState *env)
+{
+    return (env->interrupt_request & (CPU_INTERRUPT_HARD));
+}
+
 static inline int cpu_halted(CPUState *env) {
     if (!env->halted)
         return 0;
-    if (env->interrupt_request & CPU_INTERRUPT_HARD) {
+    if (cpu_has_work(env)) {
         env->halted = 0;
         return 0;
     }

diff --git a/target-mips/exec.h b/target-mips/exec.h
index 18765f967945a4adbf155e7874e64de9d48a2059..8a118bb6b3b18da5ec67a692c33692d91ad4a826 100644 (file)
--- a/target-mips/exec.h
+++ b/target-mips/exec.h
@@ -33,12 +33,18 @@ static inline void regs_to_env(void)
 {
 }
 
+static inline int cpu_has_work(CPUState *env)
+{
+    return (env->interrupt_request &
+            (CPU_INTERRUPT_HARD | CPU_INTERRUPT_TIMER));
+}
+
+
 static inline int cpu_halted(CPUState *env)
 {
     if (!env->halted)
         return 0;
-    if (env->interrupt_request &
-        (CPU_INTERRUPT_HARD | CPU_INTERRUPT_TIMER)) {
+    if (cpu_has_work(env)) {
         env->halted = 0;
         return 0;
     }

diff --git a/target-ppc/exec.h b/target-ppc/exec.h
index d89698c63a2f4f67020317297a998e1463297290..f6b9ee6c83a2bba53a5cb38951a319fe55656293 100644 (file)
--- a/target-ppc/exec.h
+++ b/target-ppc/exec.h
@@ -44,11 +44,17 @@ static always_inline void regs_to_env (void)
 {
 }
 
+static always_inline int cpu_has_work(CPUState *env)
+{
+    return (msr_ee && (env->interrupt_request & CPU_INTERRUPT_HARD));
+}
+
+
 static always_inline int cpu_halted (CPUState *env)
 {
     if (!env->halted)
         return 0;
-    if (msr_ee && (env->interrupt_request & CPU_INTERRUPT_HARD)) {
+    if (cpu_has_work(env)) {
         env->halted = 0;
         return 0;
     }

diff --git a/target-sh4/exec.h b/target-sh4/exec.h
index ad26990c5e5707d72e5eb9cf869fa7955558238a..d2926750b3c76a227ce1914b08b693b5fa2c4429 100644 (file)
--- a/target-sh4/exec.h
+++ b/target-sh4/exec.h
@@ -28,10 +28,15 @@ register struct CPUSH4State *env asm(AREG0);
 #include "cpu.h"
 #include "exec-all.h"
 
+static inline int cpu_has_work(CPUState *env)
+{
+    return (env->interrupt_request & CPU_INTERRUPT_HARD);
+}
+
 static inline int cpu_halted(CPUState *env) {
     if (!env->halted)
         return 0;
-    if (env->interrupt_request & CPU_INTERRUPT_HARD) {
+    if (cpu_has_work(env)) {
         env->halted = 0;
         env->intr_at_halt = 1;
         return 0;

diff --git a/target-sparc/exec.h b/target-sparc/exec.h
index 36fd1176fc5e0750288a349dcc8fbbce535b6491..f37c8ad994f81852eb19f39b0fbec9bf46e6d679 100644 (file)
--- a/target-sparc/exec.h
+++ b/target-sparc/exec.h
@@ -24,10 +24,17 @@ static inline void regs_to_env(void)
 /* op_helper.c */
 void do_interrupt(CPUState *env);
 
+static inline int cpu_has_work(CPUState *env1)
+{
+    return (env1->interrupt_request & CPU_INTERRUPT_HARD) &&
+           (env1->psret != 0);
+}
+
+
 static inline int cpu_halted(CPUState *env1) {
     if (!env1->halted)
         return 0;
-    if ((env1->interrupt_request & CPU_INTERRUPT_HARD) && (env1->psret != 0)) {
+    if (cpu_has_work(env1)) {
         env1->halted = 0;
         return 0;
     }