media: i2c: ov7670: 0 instead of -EINVAL was returned

If the media bus is unsupported, then return -EINVAL. Instead it
returned 'ret' which happened to be 0.

This fixes a smatch warning:

ov7670.c:1843 ov7670_parse_dt() warn: missing error code? 'ret'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 01b8444828fc ("media: v4l2: i2c: ov7670: Implement OF mbus configuration")
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c
index 27db0a07de1fa6b52fb5b1263b6d54f8b0814fa3..b1bb0833571e82b04036f2d18386850155ada080 100644 (file)
--- a/drivers/media/i2c/ov7670.c
+++ b/drivers/media/i2c/ov7670.c
@@ -1840,7 +1840,7 @@ static int ov7670_parse_dt(struct device *dev,
 
        if (bus_cfg.bus_type != V4L2_MBUS_PARALLEL) {
                dev_err(dev, "Unsupported media bus type\n");
-               return ret;
+               return -EINVAL;
        }
        info->mbus_config = bus_cfg.bus.parallel.flags;