media: staging: media: tegra-video: Use swap macro
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 29 Apr 2024 15:04:49 +0000 (16:04 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 3 May 2024 10:10:00 +0000 (11:10 +0100)
Makes the code simpler and cocci happier:

drivers/staging/media/tegra-video/tegra20.c:324:44-45: WARNING opportunity for swap()

Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-10-3c4865f5a4b0@chromium.org
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/tegra-video/tegra20.c

index 630e2ff987a37ff92fe62540f73c9bd487c004df..7b8f8f810b3564daaa73309813a59a6b036b317e 100644 (file)
@@ -317,13 +317,8 @@ static void tegra20_channel_queue_setup(struct tegra_vi_channel *chan)
                chan->addr_offset_v = chan->addr_offset_u + stride * height / 4;
 
                /* For YVU420, we swap the locations of the U and V planes. */
-               if (chan->format.pixelformat == V4L2_PIX_FMT_YVU420) {
-                       unsigned long temp;
-
-                       temp = chan->addr_offset_u;
-                       chan->addr_offset_u = chan->addr_offset_v;
-                       chan->addr_offset_v = temp;
-               }
+               if (chan->format.pixelformat == V4L2_PIX_FMT_YVU420)
+                       swap(chan->addr_offset_u, chan->addr_offset_v);
 
                chan->start_offset_u = chan->addr_offset_u;
                chan->start_offset_v = chan->addr_offset_v;