octeontx2-af: returning uninitialized variable

Fix coverity error 'use of uninitialized variable'. err is uninitialized
and is returned which can lead to unintended results. err has been replaced
with -einval.
Coverity issue: 1518921 (uninitialized scalar variable)

Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
index ff71e6a87741982b690333faf08ee0485d4bcb96..1195b690f483db8696a093901ef22a2320d7e232 100644 (file)
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
@@ -1959,7 +1959,7 @@ int rvu_npc_exact_init(struct rvu *rvu)
                        dev_err(rvu->dev,
                                "%s: failed to set drop info for cgx=%d, lmac=%d, chan=%llx\n",
                                __func__, cgx_id, lmac_id, chan_val);
-                       return err;
+                       return -EINVAL;
                }
 
                err = npc_install_mcam_drop_rule(rvu, *drop_mcam_idx,