cxl: Remove unnecessary cxl_pci_window_alignment()
authorBjorn Helgaas <bhelgaas@google.com>
Mon, 5 Dec 2022 22:32:31 +0000 (16:32 -0600)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 6 Dec 2022 12:15:06 +0000 (23:15 +1100)
cxl_pci_window_alignment() is referenced only via the struct
pci_controller_ops.window_alignment function pointer, and only in the
powerpc implementation of pcibios_window_alignment().

pcibios_window_alignment() defaults to returning 1 if the function pointer
is NULL, which is the same was what cxl_pci_window_alignment() does.

cxl_pci_window_alignment() is unnecessary, so remove it.  No functional
change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221205223231.1268085-1-helgaas@kernel.org
drivers/misc/cxl/vphb.c

index 1264253cc07bc749845af3bf8d925ce43e31c772..6332db8044bd6d3703be62eaeb362d336f9220d5 100644 (file)
@@ -67,12 +67,6 @@ static void cxl_pci_disable_device(struct pci_dev *dev)
        }
 }
 
-static resource_size_t cxl_pci_window_alignment(struct pci_bus *bus,
-                                               unsigned long type)
-{
-       return 1;
-}
-
 static void cxl_pci_reset_secondary_bus(struct pci_dev *dev)
 {
        /* Should we do an AFU reset here ? */
@@ -200,7 +194,6 @@ static struct pci_controller_ops cxl_pci_controller_ops =
        .enable_device_hook = cxl_pci_enable_device_hook,
        .disable_device = cxl_pci_disable_device,
        .release_device = cxl_pci_disable_device,
-       .window_alignment = cxl_pci_window_alignment,
        .reset_secondary_bus = cxl_pci_reset_secondary_bus,
        .setup_msi_irqs = cxl_setup_msi_irqs,
        .teardown_msi_irqs = cxl_teardown_msi_irqs,