dmaengine: sprd: Define the DMA transfer step type
authorEric Long <eric.long@spreadtrum.com>
Thu, 19 Apr 2018 02:00:46 +0000 (10:00 +0800)
committerVinod Koul <vkoul@kernel.org>
Fri, 27 Apr 2018 06:24:55 +0000 (11:54 +0530)
Define the DMA transfer step type to make code more readable.

Signed-off-by: Eric Long <eric.long@spreadtrum.com>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sprd-dma.c

index b106e8a60af642ad213e1a21a08b24d749d4673f..dcfa4179bf9ef94a673e539f36169ae622930096 100644 (file)
 #define SPRD_DMA_SRC_TRSF_STEP_OFFSET  0
 #define SPRD_DMA_TRSF_STEP_MASK                GENMASK(15, 0)
 
+/* define the DMA transfer step type */
+#define SPRD_DMA_NONE_STEP             0
+#define SPRD_DMA_BYTE_STEP             1
+#define SPRD_DMA_SHORT_STEP            2
+#define SPRD_DMA_WORD_STEP             4
+#define SPRD_DMA_DWORD_STEP            8
+
 #define SPRD_DMA_SOFTWARE_UID          0
 
 /*
@@ -598,16 +605,16 @@ static int sprd_dma_config(struct dma_chan *chan, struct sprd_dma_desc *sdesc,
 
        if (IS_ALIGNED(len, 4)) {
                datawidth = 2;
-               src_step = 4;
-               des_step = 4;
+               src_step = SPRD_DMA_WORD_STEP;
+               des_step = SPRD_DMA_WORD_STEP;
        } else if (IS_ALIGNED(len, 2)) {
                datawidth = 1;
-               src_step = 2;
-               des_step = 2;
+               src_step = SPRD_DMA_SHORT_STEP;
+               des_step = SPRD_DMA_SHORT_STEP;
        } else {
                datawidth = 0;
-               src_step = 1;
-               des_step = 1;
+               src_step = SPRD_DMA_BYTE_STEP;
+               des_step = SPRD_DMA_BYTE_STEP;
        }
 
        fragment_len = SPRD_DMA_MEMCPY_MIN_SIZE;