USB: fotg210: fix memory leak with using debugfs_lookup()

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20230202153235.2412790-5-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/fotg210/fotg210-hcd.c b/drivers/usb/fotg210/fotg210-hcd.c
index 613d29f04bcb358c97bffe2095b946a9621a9f78..929106c16b29b5cff1cfd051e9b9a00f1b0e222d 100644 (file)
--- a/drivers/usb/fotg210/fotg210-hcd.c
+++ b/drivers/usb/fotg210/fotg210-hcd.c
@@ -861,7 +861,7 @@ static inline void remove_debug_files(struct fotg210_hcd *fotg210)
 {
        struct usb_bus *bus = &fotg210_to_hcd(fotg210)->self;
 
-       debugfs_remove(debugfs_lookup(bus->bus_name, fotg210_debug_root));
+       debugfs_lookup_and_remove(bus->bus_name, fotg210_debug_root);
 }
 
 /* handshake - spin reading hc until handshake completes or fails