devlink: add forgotten devlink instance lock assertion to devl_param_driverinit_value...
authorJiri Pirko <jiri@nvidia.com>
Fri, 10 Feb 2023 10:01:31 +0000 (11:01 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Feb 2023 09:49:14 +0000 (09:49 +0000)
Driver calling devl_param_driverinit_value_set() has to hold devlink
instance lock while doing that. Put an assertion there.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/devlink/leftover.c

index d4c896f8990564cbed553a31764a7741d6cf2398..3569706c49e11082fcbd6fd8cfa48ca1ed0ee735 100644 (file)
@@ -9681,6 +9681,8 @@ void devl_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
 {
        struct devlink_param_item *param_item;
 
+       devl_assert_locked(devlink);
+
        param_item = devlink_param_find_by_id(&devlink->params, param_id);
        if (WARN_ON(!param_item))
                return;