iio: tsl2772: Use devm_add_action_or_reset

Use devm_add_action_or_reset to remove the call to
tsl2772_disable_regulators_action to simplify the error path.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Reviewed-by: Brian Masney <masneyb@onstation.org>
Tested-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
index 83cece921843c64594f67d60e41d79cea9b4ac89..29cfd8ae2700809233d0358bbca96a502e3a7366 100644 (file)
--- a/drivers/iio/light/tsl2772.c
+++ b/drivers/iio/light/tsl2772.c
@@ -1807,10 +1807,10 @@ static int tsl2772_probe(struct i2c_client *clientp,
                return PTR_ERR(chip->vdd_supply);
        }
 
-       ret = devm_add_action(&clientp->dev, tsl2772_disable_regulators_action,
-                             chip);
+       ret = devm_add_action_or_reset(&clientp->dev,
+                                       tsl2772_disable_regulators_action,
+                                       chip);
        if (ret < 0) {
-               tsl2772_disable_regulators_action(chip);
                dev_err(&clientp->dev, "Failed to setup regulator cleanup action %d\n",
                        ret);
                return ret;