HID: intel-ish-hid: ipc: Add check for pci_alloc_irq_vectors
authorChen Ni <nichen@iscas.ac.cn>
Mon, 29 Apr 2024 08:54:22 +0000 (16:54 +0800)
committerJiri Kosina <jkosina@suse.com>
Mon, 6 May 2024 21:55:23 +0000 (23:55 +0200)
Add a check for the return value of pci_alloc_irq_vectors() and return
error if it fails.

[jkosina@suse.com: reworded changelog based on Srinivas' suggestion]
Fixes: 74fbc7d371d9 ("HID: intel-ish-hid: add MSI interrupt support")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/intel-ish-hid/ipc/pci-ish.c

index 56bd4f02f3191b1bfb2ea53adce2bc8f6788b3fb..4b8232360cc46a1cc322fbd0e4857a0cd426a1b4 100644 (file)
@@ -173,6 +173,11 @@ static int ish_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
        /* request and enable interrupt */
        ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
+       if (ret < 0) {
+               dev_err(dev, "ISH: Failed to allocate IRQ vectors\n");
+               return ret;
+       }
+
        if (!pdev->msi_enabled && !pdev->msix_enabled)
                irq_flag = IRQF_SHARED;