wifi: carl9170: remove unnecessary (void*) conversions
authorWu Yunchuan <yunchuan@nfschina.com>
Sat, 30 Sep 2023 04:54:47 +0000 (07:54 +0300)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 2 Oct 2023 16:56:51 +0000 (19:56 +0300)
No need cast (void *) to (struct ar9170 *), (u8 *) or (void*).

Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230919044916.523308-1-yunchuan@nfschina.com
drivers/net/wireless/ath/carl9170/usb.c

index e4eb666c6eea41ab51c5cf8c0c5e60a9db5f4ad7..c4edf835594108698ba5183d74f7569ddcfca8ac 100644 (file)
@@ -178,7 +178,7 @@ static void carl9170_usb_tx_data_complete(struct urb *urb)
        switch (urb->status) {
        /* everything is fine */
        case 0:
-               carl9170_tx_callback(ar, (void *)urb->context);
+               carl9170_tx_callback(ar, urb->context);
                break;
 
        /* disconnect */
@@ -369,7 +369,7 @@ void carl9170_usb_handle_tx_err(struct ar9170 *ar)
        struct urb *urb;
 
        while ((urb = usb_get_from_anchor(&ar->tx_err))) {
-               struct sk_buff *skb = (void *)urb->context;
+               struct sk_buff *skb = urb->context;
 
                carl9170_tx_drop(ar, skb);
                carl9170_tx_callback(ar, skb);
@@ -397,7 +397,7 @@ static void carl9170_usb_tasklet(struct tasklet_struct *t)
 
 static void carl9170_usb_rx_complete(struct urb *urb)
 {
-       struct ar9170 *ar = (struct ar9170 *)urb->context;
+       struct ar9170 *ar = urb->context;
        int err;
 
        if (WARN_ON_ONCE(!ar))
@@ -559,7 +559,7 @@ static int carl9170_usb_flush(struct ar9170 *ar)
        int ret, err = 0;
 
        while ((urb = usb_get_from_anchor(&ar->tx_wait))) {
-               struct sk_buff *skb = (void *)urb->context;
+               struct sk_buff *skb = urb->context;
                carl9170_tx_drop(ar, skb);
                carl9170_tx_callback(ar, skb);
                usb_free_urb(urb);
@@ -668,7 +668,7 @@ int carl9170_exec_cmd(struct ar9170 *ar, const enum carl9170_cmd_oids cmd,
                memcpy(ar->cmd.data, payload, plen);
 
        spin_lock_bh(&ar->cmd_lock);
-       ar->readbuf = (u8 *)out;
+       ar->readbuf = out;
        ar->readlen = outlen;
        spin_unlock_bh(&ar->cmd_lock);