mt76: do not reset MIB counters in get_stats callback
authorLorenzo Bianconi <lorenzo@kernel.org>
Tue, 19 Oct 2021 10:12:27 +0000 (12:12 +0200)
committerFelix Fietkau <nbd@nbd.name>
Wed, 20 Oct 2021 08:37:02 +0000 (10:37 +0200)
MIB counters are used for ethtool stats as well

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/main.c
drivers/net/wireless/mediatek/mt76/mt7915/main.c
drivers/net/wireless/mediatek/mt76/mt7921/main.c

index d5bcffef7122f0d89eac3d218fbacaf187864eb5..343e157261cac3bea54fc7e8d938a2d6696b270f 100644 (file)
@@ -862,8 +862,6 @@ mt7615_get_stats(struct ieee80211_hw *hw,
        stats->dot11FCSErrorCount = mib->fcs_err_cnt;
        stats->dot11ACKFailureCount = mib->ack_fail_cnt;
 
-       memset(mib, 0, sizeof(*mib));
-
        mt7615_mutex_release(phy->dev);
 
        return 0;
index 48d0e07954156fd4dc5c9551176f4e5e5aac3d0d..8be78917dee9ab27cd97b7a197830f1708fe6ad9 100644 (file)
@@ -811,13 +811,12 @@ mt7915_get_stats(struct ieee80211_hw *hw,
        struct mib_stats *mib = &phy->mib;
 
        mutex_lock(&dev->mt76.mutex);
+
        stats->dot11RTSSuccessCount = mib->rts_cnt;
        stats->dot11RTSFailureCount = mib->rts_retries_cnt;
        stats->dot11FCSErrorCount = mib->fcs_err_cnt;
        stats->dot11ACKFailureCount = mib->ack_fail_cnt;
 
-       memset(mib, 0, sizeof(*mib));
-
        mutex_unlock(&dev->mt76.mutex);
 
        return 0;
index d968990dac6e095505abf94a785f4ac9085e370b..22d5a0adb5adb21c03755e119bd5fda5c810fee6 100644 (file)
@@ -856,8 +856,6 @@ mt7921_get_stats(struct ieee80211_hw *hw,
        stats->dot11FCSErrorCount = mib->fcs_err_cnt;
        stats->dot11ACKFailureCount = mib->ack_fail_cnt;
 
-       memset(mib, 0, sizeof(*mib));
-
        mt7921_mutex_release(phy->dev);
 
        return 0;