bcachefs: Fix bch2_btree_iter_advance()
authorKent Overstreet <kent.overstreet@gmail.com>
Thu, 28 Oct 2021 20:34:17 +0000 (16:34 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:09:15 +0000 (17:09 -0400)
Was popping an assertion on !BTREE_ITER_ALL_SNAPSHOTS iters when getting
to the end.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
fs/bcachefs/btree_iter.c

index c1dc33248265aad17ac166bd5e3ee33315a99492..51dd10518214ca523f784ae60fcbeaa1197b4e12 100644 (file)
@@ -2021,7 +2021,9 @@ err:
 inline bool bch2_btree_iter_advance(struct btree_iter *iter)
 {
        struct bpos pos = iter->k.p;
-       bool ret = bpos_cmp(pos, SPOS_MAX) != 0;
+       bool ret = (iter->flags & BTREE_ITER_ALL_SNAPSHOTS
+                   ? bpos_cmp(pos, SPOS_MAX)
+                   : bkey_cmp(pos, SPOS_MAX)) != 0;
 
        if (ret && !(iter->flags & BTREE_ITER_IS_EXTENTS))
                pos = bkey_successor(iter, pos);