ALSA: usb: stream: fix potential memory leak during uac3 interface parsing

UAC3 channel map is created during interface parsing,
and in some cases was not freed in failure paths.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/usb/stream.c b/sound/usb/stream.c
index bce31524095554a4276d67236d54ba3298cc8610..d16e1c23f4e90cc8ab64ed9306ad02d2c15a2591 100644 (file)
--- a/sound/usb/stream.c
+++ b/sound/usb/stream.c
@@ -982,13 +982,16 @@ snd_usb_get_audioformat_uac3(struct snd_usb_audio *chip,
 
        dev_err(&dev->dev, "%u:%d : bogus bTerminalLink %d\n",
                        iface_no, altno, as->bTerminalLink);
+       kfree(chmap);
        return NULL;
 
 found_clock:
        fp = audio_format_alloc_init(chip, alts, UAC_VERSION_3, iface_no,
                                     altset_idx, altno, num_channels, clock);
-       if (!fp)
+       if (!fp) {
+               kfree(chmap);
                return ERR_PTR(-ENOMEM);
+       }
 
        fp->chmap = chmap;
 
@@ -1009,6 +1012,7 @@ found_clock:
                                                               iface_no);
                /* ok, let's parse further... */
                if (snd_usb_parse_audio_format_v3(chip, fp, as, stream) < 0) {
+                       kfree(fp->chmap);
                        kfree(fp->rate_table);
                        kfree(fp);
                        return NULL;