projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a002f65
)
mfd: sta2x11: Use GFP_KERNEL instead of GFP_ATOMIC
author
Julia Lawall
<Julia.Lawall@inria.fr>
Thu, 10 Feb 2022 20:42:23 +0000
(21:42 +0100)
committer
Lee Jones
<lee.jones@linaro.org>
Tue, 8 Mar 2022 09:44:05 +0000
(09:44 +0000)
pci_driver probe functions aren't called with locks held and
thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.
Problem found with Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link:
https://lore.kernel.org/r/20220210204223.104181-10-Julia.Lawall@inria.fr
drivers/mfd/sta2x11-mfd.c
patch
|
blob
|
history
diff --git
a/drivers/mfd/sta2x11-mfd.c
b/drivers/mfd/sta2x11-mfd.c
index 1819c8fe4d8f65ae000094b5e46d2b3d7fcc12e8..02cc49daf2e3cff5a8c108484356b7ff9791f305 100644
(file)
--- a/
drivers/mfd/sta2x11-mfd.c
+++ b/
drivers/mfd/sta2x11-mfd.c
@@
-590,7
+590,7
@@
static int sta2x11_mfd_probe(struct pci_dev *pdev,
/* Record this pdev before mfd_add_devices: their probe looks for it */
if (!sta2x11_mfd_find(pdev))
- sta2x11_mfd_add(pdev, GFP_
ATOMIC
);
+ sta2x11_mfd_add(pdev, GFP_
KERNEL
);
/* Just 2 bars for all mfd's at present */
for (i = 0; i < 2; i++) {