drm/msm: Fix MSM_INFO_GET_IOVA with carveout
authorIskren Chernev <iskren.chernev@gmail.com>
Sat, 2 Jan 2021 20:24:37 +0000 (22:24 +0200)
committerRob Clark <robdclark@chromium.org>
Sun, 31 Jan 2021 18:40:26 +0000 (10:40 -0800)
The msm_gem_get_iova should be guarded with gpu != NULL and not aspace
!= NULL, because aspace is NULL when using vram carveout.

Fixes: 933415e24bd0d ("drm/msm: Add support for private address space instances")
Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
Tested-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/msm_drv.c

index 108c405e03dd92e0535cd88c05b019c4be77fc39..94525ac76d4e6f94947e7f722d84fb6630c31e4c 100644 (file)
@@ -788,9 +788,10 @@ static int msm_ioctl_gem_info_iova(struct drm_device *dev,
                struct drm_file *file, struct drm_gem_object *obj,
                uint64_t *iova)
 {
+       struct msm_drm_private *priv = dev->dev_private;
        struct msm_file_private *ctx = file->driver_priv;
 
-       if (!ctx->aspace)
+       if (!priv->gpu)
                return -EINVAL;
 
        /*