hw/riscv: spike: Add '/chosen/stdout-path' in device tree unconditionally
authorBin Meng <bin.meng@windriver.com>
Thu, 21 Apr 2022 05:56:28 +0000 (13:56 +0800)
committerAlistair Francis <alistair.francis@wdc.com>
Fri, 29 Apr 2022 00:47:45 +0000 (10:47 +1000)
At present the adding '/chosen/stdout-path' property in device tree
is determined by whether a kernel command line is provided, which is
wrong. It should be added unconditionally.

Fixes: 8d8897accb1c ("hw/riscv: spike: Allow using binary firmware as bios")
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20220421055629.1177285-1-bmeng.cn@gmail.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
hw/riscv/spike.c

index d059a67f9b72abaafdd6d3a89d704e392addbf27..1562b000bb5a0a03b76bcf0501b7f1e84a53240c 100644 (file)
@@ -174,10 +174,11 @@ static void create_fdt(SpikeState *s, const MemMapEntry *memmap,
 
     riscv_socket_fdt_write_distance_matrix(mc, fdt);
 
+    qemu_fdt_add_subnode(fdt, "/chosen");
+    qemu_fdt_setprop_string(fdt, "/chosen", "stdout-path", "/htif");
+
     if (cmdline) {
-        qemu_fdt_add_subnode(fdt, "/chosen");
         qemu_fdt_setprop_string(fdt, "/chosen", "bootargs", cmdline);
-        qemu_fdt_setprop_string(fdt, "/chosen", "stdout-path", "/htif");
     }
 }