wifi: b43: Convert sprintf/snprintf to sysfs_emit

Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

sprintf() will be converted as weel if they have.

Generally, this patch is generated by
make coccicheck M=<path/to/file> MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci

No functional change intended

CC: Larry Finger <Larry.Finger@lwfinger.net>
CC: Kalle Valo <kvalo@kernel.org>
CC: linux-wireless@vger.kernel.org
CC: b43-dev@lists.infradead.org
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240315055211.1347548-2-lizhijian@fujitsu.com

diff --git a/drivers/net/wireless/broadcom/b43/sysfs.c b/drivers/net/wireless/broadcom/b43/sysfs.c
index 0679d132968f153e450962bf2c96ce2dbb6758e9..261b2b746a9c90292a42d6433bac58dc35d3dba8 100644 (file)
--- a/drivers/net/wireless/broadcom/b43/sysfs.c
+++ b/drivers/net/wireless/broadcom/b43/sysfs.c
@@ -53,19 +53,14 @@ static ssize_t b43_attr_interfmode_show(struct device *dev,
 
        switch (wldev->phy.g->interfmode) {
        case B43_INTERFMODE_NONE:
-               count =
-                   snprintf(buf, PAGE_SIZE,
-                            "0 (No Interference Mitigation)\n");
+               count = sysfs_emit(buf, "0 (No Interference Mitigation)\n");
                break;
        case B43_INTERFMODE_NONWLAN:
-               count =
-                   snprintf(buf, PAGE_SIZE,
-                            "1 (Non-WLAN Interference Mitigation)\n");
+               count = sysfs_emit(buf,
+                                  "1 (Non-WLAN Interference Mitigation)\n");
                break;
        case B43_INTERFMODE_MANUALWLAN:
-               count =
-                   snprintf(buf, PAGE_SIZE,
-                            "2 (WLAN Interference Mitigation)\n");
+               count = sysfs_emit(buf, "2 (WLAN Interference Mitigation)\n");
                break;
        default:
                B43_WARN_ON(1);

diff --git a/drivers/net/wireless/broadcom/b43legacy/sysfs.c b/drivers/net/wireless/broadcom/b43legacy/sysfs.c
index eec087ca30e6e81c7533f3f161476eeb543d76d7..d988fe541bf73b3944757f1740f2165037e3b6c9 100644 (file)
--- a/drivers/net/wireless/broadcom/b43legacy/sysfs.c
+++ b/drivers/net/wireless/broadcom/b43legacy/sysfs.c
@@ -75,16 +75,14 @@ static ssize_t b43legacy_attr_interfmode_show(struct device *dev,
 
        switch (wldev->phy.interfmode) {
        case B43legacy_INTERFMODE_NONE:
-               count = snprintf(buf, PAGE_SIZE, "0 (No Interference"
-                                " Mitigation)\n");
+               count = sysfs_emit(buf, "0 (No Interference Mitigation)\n");
                break;
        case B43legacy_INTERFMODE_NONWLAN:
-               count = snprintf(buf, PAGE_SIZE, "1 (Non-WLAN Interference"
-                                " Mitigation)\n");
+               count = sysfs_emit(buf,
+                                  "1 (Non-WLAN Interference Mitigation)\n");
                break;
        case B43legacy_INTERFMODE_MANUALWLAN:
-               count = snprintf(buf, PAGE_SIZE, "2 (WLAN Interference"
-                                " Mitigation)\n");
+               count = sysfs_emit(buf, "2 (WLAN Interference Mitigation)\n");
                break;
        default:
                B43legacy_WARN_ON(1);
@@ -155,11 +153,9 @@ static ssize_t b43legacy_attr_preamble_show(struct device *dev,
        mutex_lock(&wldev->wl->mutex);
 
        if (wldev->short_preamble)
-               count = snprintf(buf, PAGE_SIZE, "1 (Short Preamble"
-                                " enabled)\n");
+               count = sysfs_emit(buf, "1 (Short Preamble enabled)\n");
        else
-               count = snprintf(buf, PAGE_SIZE, "0 (Short Preamble"
-                                " disabled)\n");
+               count = sysfs_emit(buf, "0 (Short Preamble disabled)\n");
 
        mutex_unlock(&wldev->wl->mutex);