drm/xe/guc: Normalize error messages with %#x
authorLucas De Marchi <lucas.demarchi@intel.com>
Sun, 11 Jun 2023 22:24:45 +0000 (15:24 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:34:14 +0000 (11:34 -0500)
One of the messages was printed without 0x prefix, so it was not clear
if it was decimal or hex: make sure to add the prefix by using %#x.
While at it, normalize the other messages in the same function to follow
the same pattern.

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://lore.kernel.org/r/20230611222447.2837573-3-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_guc.c

index e51d8fb4a354a95bdc79e989a088cf1455de1a5c..43f862aaacbefe534ed9096004b3fa52ebd4a254 100644 (file)
@@ -647,7 +647,7 @@ retry:
                             GUC_HXG_MSG_0_ORIGIN, 50000, &reply, false);
        if (ret) {
 timeout:
-               drm_err(&xe->drm, "mmio request 0x%08x: no reply 0x%08x\n",
+               drm_err(&xe->drm, "mmio request %#x: no reply %#x\n",
                        request[0], reply);
                return ret;
        }
@@ -673,7 +673,7 @@ timeout:
            GUC_HXG_TYPE_NO_RESPONSE_RETRY) {
                u32 reason = FIELD_GET(GUC_HXG_RETRY_MSG_0_REASON, header);
 
-               drm_dbg(&xe->drm, "mmio request %#x: retrying, reason %u\n",
+               drm_dbg(&xe->drm, "mmio request %#x: retrying, reason %#x\n",
                        request[0], reason);
                goto retry;
        }
@@ -683,7 +683,7 @@ timeout:
                u32 hint = FIELD_GET(GUC_HXG_FAILURE_MSG_0_HINT, header);
                u32 error = FIELD_GET(GUC_HXG_FAILURE_MSG_0_ERROR, header);
 
-               drm_err(&xe->drm, "mmio request %#x: failure %x/%u\n",
+               drm_err(&xe->drm, "mmio request %#x: failure %#x/%#x\n",
                        request[0], error, hint);
                return -ENXIO;
        }