PCI: keystone: Fix link training retries initiation
authorYurii Monakov <monakov.y@gmail.com>
Tue, 17 Dec 2019 11:38:36 +0000 (14:38 +0300)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Fri, 10 Jan 2020 17:23:22 +0000 (17:23 +0000)
ks_pcie_stop_link() function does not clear LTSSM_EN_VAL bit so
link training was not triggered more than once after startup.
In configurations where link can be unstable during early boot,
for example, under low temperature, it will never be established.

Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver")
Signed-off-by: Yurii Monakov <monakov.y@gmail.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Andrew Murray <andrew.murray@arm.com>
Cc: stable@vger.kernel.org
drivers/pci/controller/dwc/pci-keystone.c

index af677254a0726574d1cd7c73e2ae27939011c2e0..d4de4f6cff8b907b972f30cd45fb18d1fbfd0db4 100644 (file)
@@ -510,7 +510,7 @@ static void ks_pcie_stop_link(struct dw_pcie *pci)
        /* Disable Link training */
        val = ks_pcie_app_readl(ks_pcie, CMD_STATUS);
        val &= ~LTSSM_EN_VAL;
-       ks_pcie_app_writel(ks_pcie, CMD_STATUS, LTSSM_EN_VAL | val);
+       ks_pcie_app_writel(ks_pcie, CMD_STATUS, val);
 }
 
 static int ks_pcie_start_link(struct dw_pcie *pci)