ASoC: soc-pcm: remove duplicate be check from dpcm_add_paths()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 27 Feb 2020 01:54:48 +0000 (10:54 +0900)
committerMark Brown <broonie@kernel.org>
Thu, 5 Mar 2020 13:15:18 +0000 (13:15 +0000)
dpcm_add_paths() checks returned be from dpcm_get_be()

static int dpcm_add_paths(...)
{
...
for_each_dapm_widgets(list, i, widget) {
...
be = dpcm_get_be(...);
...
/* make sure BE is a real BE */
=> if (!be->dai_link->no_pcm)
continue;
...
}
...
}

But, dpcm_get_be() itself is checking it already.

dpcm_get_be(...)
{
...
for_each_card_rtds(card, be) {
=> if (!be->dai_link->no_pcm)
continue;
...
if (...)
=> return be;
}

return NULL
}

This patch removes duplicate check

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/87lfoo7q1j.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c

index 8c27eb4d5e4c6d9aa8a8fed79f964881a193ba89..e3a2c4f7757bfa7c70a6ccdb4aa518eaf07bc969 100644 (file)
@@ -1690,10 +1690,6 @@ static int dpcm_add_paths(struct snd_soc_pcm_runtime *fe, int stream,
                        continue;
                }
 
-               /* make sure BE is a real BE */
-               if (!be->dai_link->no_pcm)
-                       continue;
-
                /* don't connect if FE is not running */
                if (!fe->dpcm[stream].runtime && !fe->fe_compr)
                        continue;