ibmvnic: Process crqs after enabling interrupts
authorSukadev Bhattiprolu <sukadev@linux.ibm.com>
Fri, 29 Oct 2021 22:03:15 +0000 (15:03 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 1 Nov 2021 13:14:52 +0000 (13:14 +0000)
Soon after registering a CRQ it is possible that we get a fail over or
maybe a CRQ_INIT from the VIOS while interrupts were disabled.

Look for any such CRQs after enabling interrupts.

Otherwise we can intermittently fail to bring up ibmvnic adapters during
boot, specially in kexec/kdump kernels.

Fixes: 032c5e82847a ("Driver for IBM System i/p VNIC protocol")
Reported-by: Vaishnavi Bhat <vaish123@in.ibm.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Reviewed-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c

index 7438138c3766abd7df444010808dc36392110623..84961a83803b70625c71b6659a8c91e94e00f04c 100644 (file)
@@ -5412,6 +5412,9 @@ static int init_crq_queue(struct ibmvnic_adapter *adapter)
        crq->cur = 0;
        spin_lock_init(&crq->lock);
 
+       /* process any CRQs that were queued before we enabled interrupts */
+       tasklet_schedule(&adapter->tasklet);
+
        return retrc;
 
 req_irq_failed: