iio: light: us5182: Use pm_runtime_resume_and_get() to replace open coding.
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 9 May 2021 11:33:46 +0000 (12:33 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 17 May 2021 12:54:26 +0000 (13:54 +0100)
Found using coccicheck script under review at:
https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/

This is a prequel to taking a closer look at the runtime pm in IIO drivers
in general.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/20210509113354.660190-21-jic23@kernel.org
drivers/iio/light/us5182d.c

index 393f27b75c75ec1d82dd2232ed2763a69e26c37f..96e4a66ddf28672f6bdb9afd96564387753e0711 100644 (file)
@@ -367,9 +367,7 @@ static int us5182d_set_power_state(struct us5182d_data *data, bool on)
                return 0;
 
        if (on) {
-               ret = pm_runtime_get_sync(&data->client->dev);
-               if (ret < 0)
-                       pm_runtime_put_noidle(&data->client->dev);
+               ret = pm_runtime_resume_and_get(&data->client->dev);
        } else {
                pm_runtime_mark_last_busy(&data->client->dev);
                ret = pm_runtime_put_autosuspend(&data->client->dev);