projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
04948e7
)
phy: sunplus: Fix an IS_ERR() vs NULL bug in sp_usb_phy_probe
author
Peng Wu
<wupeng58@huawei.com>
Sun, 11 Sep 2022 06:00:53 +0000
(06:00 +0000)
committer
Vinod Koul
<vkoul@kernel.org>
Fri, 4 Nov 2022 18:59:57 +0000
(
00:29
+0530)
The devm_ioremap() function returns NULL on error, it doesn't return
error pointers.
Fixes: 99d9ccd973852 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
Signed-off-by: Peng Wu <wupeng58@huawei.com>
Link:
https://lore.kernel.org/r/20220911060053.123594-1-wupeng58@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/sunplus/phy-sunplus-usb2.c
patch
|
blob
|
history
diff --git
a/drivers/phy/sunplus/phy-sunplus-usb2.c
b/drivers/phy/sunplus/phy-sunplus-usb2.c
index b932087c55b2943dde6519b684380da802e7f204..e827b79f6d493cb9c1571221d7940e16741b0a2a 100644
(file)
--- a/
drivers/phy/sunplus/phy-sunplus-usb2.c
+++ b/
drivers/phy/sunplus/phy-sunplus-usb2.c
@@
-256,8
+256,8
@@
static int sp_usb_phy_probe(struct platform_device *pdev)
usbphy->moon4_res_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "moon4");
usbphy->moon4_regs = devm_ioremap(&pdev->dev, usbphy->moon4_res_mem->start,
resource_size(usbphy->moon4_res_mem));
- if (
IS_ERR(usbphy->moon4_regs)
)
- return
PTR_ERR(usbphy->moon4_regs)
;
+ if (
!usbphy->moon4_regs
)
+ return
-ENOMEM
;
usbphy->phy_clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(usbphy->phy_clk))