ACPICA: executer/exsystem: Warn about sleeps greater than 10 ms

ACPICA commit 2a0d1d475e7ea1c815bee1e0692d81db9a7c909c

Quick boottime is important, so warn about sleeps greater than 10 ms.

Distribution Linux kernels reach initrd in 350 ms, so excessive delays
should be called out. 10 ms is chosen randomly, but three of such delays
would already make up ten percent of the boottime.

Link: https://github.com/acpica/acpica/commit/2a0d1d47
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reported-by: kernel test robot <lkp@intel.com>

diff --git a/drivers/acpi/acpica/exsystem.c b/drivers/acpi/acpica/exsystem.c
index 754cf289fc01e9e0be7774d283ded441a4495e42..b9b98a7cad4dc5e93a125357097bd27aec0902a5 100644 (file)
--- a/drivers/acpi/acpica/exsystem.c
+++ b/drivers/acpi/acpica/exsystem.c
@@ -169,6 +169,16 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long_ms)
 
        acpi_ex_exit_interpreter();
 
+       /*
+        * Warn users about excessive sleep times, so ASL code can be improved to
+        * use polling or similar techniques.
+        */
+       if (how_long_ms > 10) {
+               ACPI_WARNING((AE_INFO,
+                             "Firmware issue: Excessive sleep time (%llu ms > 10 ms) in ACPI Control Method",
+                             how_long_us));
+       }
+
        /*
         * For compatibility with other ACPI implementations and to prevent
         * accidental deep sleeps, limit the sleep time to something reasonable.