bcachefs: Fix use after free in bch2_check_fix_ptrs()

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

diff --git a/fs/bcachefs/btree_gc.c b/fs/bcachefs/btree_gc.c
index 6d32ac9be2438ffcc8beb651def55a31257c24dd..26e51af9acdcf0845fed36d65ba7cf946234b0d1 100644 (file)
--- a/fs/bcachefs/btree_gc.c
+++ b/fs/bcachefs/btree_gc.c
@@ -691,12 +691,6 @@ found:
                        }
                }
 
-               ret = bch2_journal_key_insert_take(c, btree_id, level, new);
-               if (ret) {
-                       kfree(new);
-                       goto err;
-               }
-
                if (level)
                        bch2_btree_node_update_key_early(trans, btree_id, level - 1, *k, new);
 
@@ -710,6 +704,12 @@ found:
                        bch_info(c, "new key %s", buf.buf);
                }
 
+               ret = bch2_journal_key_insert_take(c, btree_id, level, new);
+               if (ret) {
+                       kfree(new);
+                       goto err;
+               }
+
                *k = bkey_i_to_s_c(new);
        }
 err: