projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
06ce078
)
wifi: libertas: Fix possible refcount leak in if_usb_probe()
author
Hangyu Hua
<hbh25y@gmail.com>
Mon, 20 Jun 2022 09:23:50 +0000
(17:23 +0800)
committer
Kalle Valo
<kvalo@kernel.org>
Wed, 27 Jul 2022 12:49:17 +0000
(15:49 +0300)
usb_get_dev will be called before lbs_get_firmware_async which means that
usb_put_dev need to be called when lbs_get_firmware_async fails.
Fixes: ce84bb69f50e ("libertas USB: convert to asynchronous firmware loading")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link:
https://lore.kernel.org/r/20220620092350.39960-1-hbh25y@gmail.com
Link:
https://lore.kernel.org/r/20220622113402.16969-1-colin.i.king@gmail.com
drivers/net/wireless/marvell/libertas/if_usb.c
patch
|
blob
|
history
diff --git
a/drivers/net/wireless/marvell/libertas/if_usb.c
b/drivers/net/wireless/marvell/libertas/if_usb.c
index 5d6dc1dd050d4a9b3b02d42f1b7f64e9c22c13db..32fdc4150b605d71669cba1ad10cad57837b61f2 100644
(file)
--- a/
drivers/net/wireless/marvell/libertas/if_usb.c
+++ b/
drivers/net/wireless/marvell/libertas/if_usb.c
@@
-287,6
+287,7
@@
static int if_usb_probe(struct usb_interface *intf,
return 0;
err_get_fw:
+ usb_put_dev(udev);
lbs_remove_card(priv);
err_add_card:
if_usb_reset_device(cardp);