pinctrl: cherryview: reduce scope of PIN_CONFIG_BIAS_HIGH_IMPEDANCE case
authorRaag Jadav <raag.jadav@intel.com>
Wed, 11 Oct 2023 06:45:33 +0000 (12:15 +0530)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 11 Oct 2023 20:40:56 +0000 (23:40 +0300)
We have a couple of pinconfig cases inside the braces which are meant for
PIN_CONFIG_BIAS_HIGH_IMPEDANCE case. Although it is valid C, it makes the
code less readable and prone to misinterpretation. Limit the braces to
PIN_CONFIG_BIAS_HIGH_IMPEDANCE case to avoid this.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/pinctrl/intel/pinctrl-cherryview.c

index 5fde4fec59c176faa691cbc9c8915fbb429deeab..b1d8f6136f99f652d027f3f959216cdfd047de7d 100644 (file)
@@ -894,6 +894,7 @@ static int chv_config_get(struct pinctrl_dev *pctldev, unsigned int pin,
                        return -EINVAL;
 
                break;
+       }
 
        case PIN_CONFIG_DRIVE_PUSH_PULL:
                if (ctrl1 & CHV_PADCTRL1_ODEN)
@@ -904,7 +905,6 @@ static int chv_config_get(struct pinctrl_dev *pctldev, unsigned int pin,
                if (!(ctrl1 & CHV_PADCTRL1_ODEN))
                        return -EINVAL;
                break;
-       }
 
        default:
                return -ENOTSUPP;