mfd: tc6393xb: Remove #ifdef guards for PM related functions
authorPaul Cercueil <paul@crapouillou.net>
Sun, 23 Oct 2022 09:48:51 +0000 (10:48 +0100)
committerLee Jones <lee@kernel.org>
Wed, 7 Dec 2022 13:28:13 +0000 (13:28 +0000)
Use the new pm_sleep_ptr() macro to handle the .suspend/.resume
callbacks.

This macro allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/tc6393xb.c

index aa903a31dd433e6abbc84f2de39cab022d29f7f6..997bb8b5881de08ca43baa772ed4098c80482e39 100644 (file)
@@ -813,7 +813,6 @@ static int tc6393xb_remove(struct platform_device *dev)
        return 0;
 }
 
-#ifdef CONFIG_PM
 static int tc6393xb_suspend(struct platform_device *dev, pm_message_t state)
 {
        struct tc6393xb_platform_data *tcpd = dev_get_platdata(&dev->dev);
@@ -876,16 +875,12 @@ static int tc6393xb_resume(struct platform_device *dev)
 
        return 0;
 }
-#else
-#define tc6393xb_suspend NULL
-#define tc6393xb_resume NULL
-#endif
 
 static struct platform_driver tc6393xb_driver = {
        .probe = tc6393xb_probe,
        .remove = tc6393xb_remove,
-       .suspend = tc6393xb_suspend,
-       .resume = tc6393xb_resume,
+       .suspend = pm_sleep_ptr(tc6393xb_suspend),
+       .resume = pm_sleep_ptr(tc6393xb_resume),
 
        .driver = {
                .name = "tc6393xb",