ksmbd: Remove duplicated codes

ksmbd_neg_token_init_mech_token() and ksmbd_neg_token_targ_resp_token()
share same implementation, unify them.

Signed-off-by: Dawei Li <set_pte_at@outlook.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/ksmbd/asn1.c b/fs/ksmbd/asn1.c
index c03eba090368227ceaeb334ee485c80b30e71196..cc6384f796759976019903343ed68f6d39d14e64 100644 (file)
--- a/fs/ksmbd/asn1.c
+++ b/fs/ksmbd/asn1.c
@@ -208,9 +208,9 @@ int ksmbd_neg_token_init_mech_type(void *context, size_t hdrlen,
        return 0;
 }
 
-int ksmbd_neg_token_init_mech_token(void *context, size_t hdrlen,
-                                   unsigned char tag, const void *value,
-                                   size_t vlen)
+static int ksmbd_neg_token_alloc(void *context, size_t hdrlen,
+                                unsigned char tag, const void *value,
+                                size_t vlen)
 {
        struct ksmbd_conn *conn = context;
 
@@ -223,17 +223,16 @@ int ksmbd_neg_token_init_mech_token(void *context, size_t hdrlen,
        return 0;
 }
 
-int ksmbd_neg_token_targ_resp_token(void *context, size_t hdrlen,
+int ksmbd_neg_token_init_mech_token(void *context, size_t hdrlen,
                                    unsigned char tag, const void *value,
                                    size_t vlen)
 {
-       struct ksmbd_conn *conn = context;
-
-       conn->mechToken = kmalloc(vlen + 1, GFP_KERNEL);
-       if (!conn->mechToken)
-               return -ENOMEM;
+       return ksmbd_neg_token_alloc(context, hdrlen, tag, value, vlen);
+}
 
-       memcpy(conn->mechToken, value, vlen);
-       conn->mechToken[vlen] = '\0';
-       return 0;
+int ksmbd_neg_token_targ_resp_token(void *context, size_t hdrlen,
+                                   unsigned char tag, const void *value,
+                                   size_t vlen)
+{
+       return ksmbd_neg_token_alloc(context, hdrlen, tag, value, vlen);
 }