staging: rtl8723bs: core: rtw_mlme_ext: Move very large data buffer onto the heap

Fixes the following W=1 kernel build warning(s):

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c: In function ‘issue_probersp’:
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:2543:1: warning: the frame size of 1096 bytes is larger than 1024 bytes [-Wframe-larger-than=]

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210414181129.1628598-54-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 9031cf7657ae91c300f13d6e99623441dbe87e3a..602d00f1e6df6405be683fbeae07ab3630625931 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -2457,9 +2457,13 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p
                        u8 *ssid_ie;
                        signed int ssid_ielen;
                        signed int ssid_ielen_diff;
-                       u8 buf[MAX_IE_SZ];
+                       u8 *buf;
                        u8 *ies = pmgntframe->buf_addr+TXDESC_OFFSET+sizeof(struct ieee80211_hdr_3addr);
 
+                       buf = rtw_zmalloc(MAX_IE_SZ);
+                       if (!buf)
+                               return;
+
                        ssid_ie = rtw_get_ie(ies+_FIXED_IE_LENGTH_, WLAN_EID_SSID, &ssid_ielen,
                                (pframe-ies)-_FIXED_IE_LENGTH_);
 
@@ -2487,6 +2491,7 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p
                                pframe += ssid_ielen_diff;
                                pattrib->pktlen += ssid_ielen_diff;
                        }
+                       kfree (buf);
                }
        } else {
                /* timestamp will be inserted by hardware */