qemu-ga: remove useless allocation
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Fri, 26 May 2017 10:13:37 +0000 (14:13 +0400)
committerMichael Tokarev <mjt@tls.msk.ru>
Sun, 4 Jun 2017 15:42:55 +0000 (18:42 +0300)
There is no need to duplicate a fixed string.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
qga/commands-posix.c

index 284ecc6d7e4f116bc9dc2badf01475af1de359dc..d8e412275e5b48f1fda7be3a9e9c10587b7b959d 100644 (file)
@@ -2197,12 +2197,10 @@ static void transfer_memory_block(GuestMemoryBlock *mem_blk, bool sys2memblk,
         }
     } else {
         if (mem_blk->online != (strncmp(status, "online", 6) == 0)) {
-            char *new_state = mem_blk->online ? g_strdup("online") :
-                                                g_strdup("offline");
+            const char *new_state = mem_blk->online ? "online" : "offline";
 
             ga_write_sysfs_file(dirfd, "state", new_state, strlen(new_state),
                                 &local_err);
-            g_free(new_state);
             if (local_err) {
                 error_free(local_err);
                 result->response =