dpaa2-switch: cleanup the egress flood of an unused FDB

In case a DPAA2 switch interface joins a bridge, the FDB used on the
port will be changed to the one associated with the bridge. What this
means exactly is that any VLAN installed on the port will need to be
removed and then installed back so that it points to the new FDB.

Once this is done, the previous FDB will become unused (no VLAN to
point to it). Even though no traffic will reach this FDB, it's best to
just cleanup the state of the FDB by zeroing its egress flood domain.

Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
index bccdaaaf5ea16660d21ed7021ecc7d53e29d14f8..f3543a2df68d542e8ee5df950e8927ae8d500489 100644 (file)
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
@@ -2004,6 +2004,7 @@ static int dpaa2_switch_port_bridge_join(struct net_device *netdev,
                                         struct netlink_ext_ack *extack)
 {
        struct ethsw_port_priv *port_priv = netdev_priv(netdev);
+       struct dpaa2_switch_fdb *old_fdb = port_priv->fdb;
        struct ethsw_core *ethsw = port_priv->ethsw_data;
        bool learn_ena;
        int err;
@@ -2025,6 +2026,11 @@ static int dpaa2_switch_port_bridge_join(struct net_device *netdev,
        if (err)
                goto err_egress_flood;
 
+       /* Recreate the egress flood domain of the FDB that we just left. */
+       err = dpaa2_switch_fdb_set_egress_flood(ethsw, old_fdb->fdb_id);
+       if (err)
+               goto err_egress_flood;
+
        err = switchdev_bridge_port_offload(netdev, netdev, NULL,
                                            NULL, NULL, false, extack);
        if (err)