wifi: iwlwifi: pcie: clean up WFPM control bits
authorJohannes Berg <johannes.berg@intel.com>
Tue, 26 Sep 2023 08:07:17 +0000 (11:07 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 23 Oct 2023 09:42:07 +0000 (11:42 +0200)
We define the same bit twice, remove the less precise
definition and use the better one instead.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230926110319.82d2744690b3.I90c08a27dca26a181dacb069184f39ece77849b5@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/iwl-prph.h
drivers/net/wireless/intel/iwlwifi/pcie/drv.c

index 6fad5b65a83626bb3c1e5fe1c352bf442fbc00ef..06d467068ff4673cda2a56f1d1dc93cdd43e8032 100644 (file)
 #define DBGI_SRAM_FIFO_POINTERS_WR_PTR_MSK             0x00000FFF
 
 enum {
-       ENABLE_WFPM = BIT(31),
        WFPM_AUX_CTL_AUX_IF_MAC_OWNER_MSK       = 0x80000000,
 };
 
index e8687683ff291bf365268910344ff482a68d2e0a..26a0953603ab4f4e234dd7872cd40ce825dd7d6b 100644 (file)
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
 /*
- * Copyright (C) 2005-2014, 2018-2021 Intel Corporation
+ * Copyright (C) 2005-2014, 2018-2023 Intel Corporation
  * Copyright (C) 2013-2015 Intel Mobile Communications GmbH
  * Copyright (C) 2016-2017 Intel Deutschland GmbH
  */
@@ -1134,7 +1134,7 @@ static int get_crf_id(struct iwl_trans *iwl_trans)
 
        /* Enable access to peripheral registers */
        val = iwl_read_umac_prph_no_grab(iwl_trans, WFPM_CTRL_REG);
-       val |= ENABLE_WFPM;
+       val |= WFPM_AUX_CTL_AUX_IF_MAC_OWNER_MSK;
        iwl_write_umac_prph_no_grab(iwl_trans, WFPM_CTRL_REG, val);
 
        /* Read crf info */