Bluetooth: hci_uart: add missing NULL check in h5_enqueue

[ Upstream commit 32cb08e958696908a9aad5e49a78d74f7e32fffb ]

Syzbot hit general protection fault in __pm_runtime_resume(). The problem
was in missing NULL check.

hu->serdev can be NULL and we should not blindly pass &serdev->dev
somewhere, since it will cause GPF.

Reported-by: syzbot+b9bd12fbed3485a3e51f@syzkaller.appspotmail.com
Fixes: d9dd833cf6d2 ("Bluetooth: hci_h5: Add runtime suspend")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
index d49a39d17d7dc0445714c881040c9a43b55cf1ca..e0ea9d25bb393eb60fd06fbe62e27ed838048163 100644 (file)
--- a/drivers/bluetooth/hci_h5.c
+++ b/drivers/bluetooth/hci_h5.c
@@ -629,9 +629,11 @@ static int h5_enqueue(struct hci_uart *hu, struct sk_buff *skb)
                break;
        }
 
-       pm_runtime_get_sync(&hu->serdev->dev);
-       pm_runtime_mark_last_busy(&hu->serdev->dev);
-       pm_runtime_put_autosuspend(&hu->serdev->dev);
+       if (hu->serdev) {
+               pm_runtime_get_sync(&hu->serdev->dev);
+               pm_runtime_mark_last_busy(&hu->serdev->dev);
+               pm_runtime_put_autosuspend(&hu->serdev->dev);
+       }
 
        return 0;
 }