projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b0576f9
)
bsr: do not use assignment in if condition
author
Naveen Kumar Parna
<parna.naveenkumar@gmail.com>
Wed, 15 May 2019 16:17:46 +0000
(21:47 +0530)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Fri, 24 May 2019 18:19:17 +0000
(20:19 +0200)
checkpatch.pl does not like assignment in if condition
Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/bsr.c
patch
|
blob
|
history
diff --git
a/drivers/char/bsr.c
b/drivers/char/bsr.c
index a6cef548e01e05d7f89436a9797a831858b60729..70de334554a8bd0926d163f4eb3e59aaa43423a5 100644
(file)
--- a/
drivers/char/bsr.c
+++ b/
drivers/char/bsr.c
@@
-322,7
+322,8
@@
static int __init bsr_init(void)
goto out_err_2;
}
- if ((ret = bsr_create_devs(np)) < 0) {
+ ret = bsr_create_devs(np);
+ if (ret < 0) {
np = NULL;
goto out_err_3;
}