scsi: sd: Don't call blk_cleanup_disk() in sd_probe()
authorChristoph Hellwig <hch@lst.de>
Mon, 23 May 2022 08:38:13 +0000 (10:38 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 24 May 2022 03:24:10 +0000 (23:24 -0400)
In SCSI the midlayer has ownership of the request_queue, so on probe
failure we must only put the gendisk, but leave the request_queue alone.

Link: https://lore.kernel.org/r/20220523083813.227935-1-hch@lst.de
Fixes: 03252259e18e ("scsi: sd: Clean up gendisk if device_add_disk() failed")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c

index c583301ff4ecfc5bbc4bfb27209460e20ed23cbf..a8f61b6ea479a7ac61a5b33175b77c8b70985297 100644 (file)
@@ -3523,7 +3523,7 @@ static int sd_probe(struct device *dev)
        error = device_add_disk(dev, gd, NULL);
        if (error) {
                put_device(&sdkp->disk_dev);
-               blk_cleanup_disk(gd);
+               put_disk(gd);
                goto out;
        }