drm/virtio: Fix error code in virtio_gpu_object_shmem_init()

In virtio_gpu_object_shmem_init() we are passing NULL to PTR_ERR, which
is returning 0/success.

Fix this by storing error value in 'ret' variable before assigning
shmem->pages to NULL.

Found using static analysis with Smatch.

Fixes: 64b88afbd92f ("drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c
index 7e75fb0fc7bd0fddbdafe643a1f375761702db75..25d399b00404c44381c6d9cb00431d28f2fb4dfa 100644 (file)
--- a/drivers/gpu/drm/virtio/virtgpu_object.c
+++ b/drivers/gpu/drm/virtio/virtgpu_object.c
@@ -169,8 +169,9 @@ static int virtio_gpu_object_shmem_init(struct virtio_gpu_device *vgdev,
        shmem->pages = drm_gem_shmem_get_sg_table(&bo->base);
        if (IS_ERR(shmem->pages)) {
                drm_gem_shmem_unpin(&bo->base);
+               ret = PTR_ERR(shmem->pages);
                shmem->pages = NULL;
-               return PTR_ERR(shmem->pages);
+               return ret;
        }
 
        if (use_dma_api) {